Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Adds Microsoft.Docker.Sdk to CLI - #8416

Merged
livarcocc merged 2 commits into
dotnet:masterfrom
yanchenw:master
Feb 9, 2018
Merged

livarcocc merged 2 commits into
dotnet:masterfrom
yanchenw:master

Conversation

@yanchenw

@yanchenw yanchenw commented Jan 17, 2018 •

Copy link
Copy Markdown

This change is to add Sdk.props and Sdk.targets of Microsoft.Docker.Sdk
into CLI. This unblocks the scenario where a VS solution contains a few
.NET Core projects as well as a docker-compose.dcproj project and people
want to build the solution from command line with .NET Core CLI. With
the Sdk.props and Sdk.targets being present in CLI, building
docker-compose.dcproj becomes no-op so it won't block building the other
.NET Core projects.

The SDK files are open-sourced under MIT license here:
https://github.com/Microsoft/DockerTools

#6178

This change is to add Sdk.props and Sdk.targets of Microsoft.Docker.Sdk
into CLI. This unblocks the scenario where a VS solution contains a few
.NET Core projects as well as a docker-compose.dcproj project and people
want to build the solution from command line with .NET Core CLI. With
the Sdk.props and Sdk.targets being present in CLI, building
docker-compose.dcproj becomes no-op so it won't block building the other
.NET Core projects.
@philcontrolf1

Copy link
Copy Markdown

@livarcocc / @MattGertz / anyone else: is there anything blocking this one being merged? Getting #6178 fixed would be wonderful.

@dasMulli

dasMulli commented Jan 31, 2018 •

Copy link
Copy Markdown

Btw since VS 15.6 is going to introduce SDKs as NuGet packages, would it be possible to upload the sdk package to NuGet in a future version?
That way the projects could be changed to Sdk=".../1.0.0" or a global.json with the msbuild-sdks version can be added to make this work. this may need a migration on the VS side but would never need any update to the CLI distribution regardless of what license is used or what changes may be necessary (since it can be done out-of-band as a new nuget package + project migration)

@MattGertz

Copy link
Copy Markdown

@livarcocc You & I haven't discussed this one. This change seems rational to me, can you let me know your thoughts here?

@livarcocc

Copy link
Copy Markdown

@MattGertz this will enable folks to build solutions that contain dcproj files in them. It is something people have been asking for for a while. This change currently targets .NET Core 2.1 Preview2. I will merge if you are ok with it.

@MattGertz

Copy link
Copy Markdown

So mote it be.

@Pzixel

Pzixel commented Apr 5, 2018

Copy link
Copy Markdown

Does it works with custom projects? I have custom project in $(CustomProjectExtensionsPath), is dontent CLI aware of it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants